[google-cloud-cpp] update to latest (v1.28.0) version #18246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonLiu1993
added
the
category:port-update
JonLiu1993
requested changes
Jun 3, 2021
There was a problem hiding this comment.
@coryan ,Thanks for your pr,please add 'vcpkg_fixup_pkgconfig()' below '
vcpkg_fixup_cmake_targets(CONFIG_PATH lib/cmake TARGET_PATH share)
in portfile.cmake
|
Done, please take another look. |
|
It looks like the grpc pkgconfig files are not fixed up; we'll need to add similar commands to that and abseil before google-cloud-cpp will be able to properly support pkgconfig. |
This reverts commit db47320.
|
Ugh. I have reverted the |
JonLiu1993
added
info:reviewed
|
Thanks a bunch; I think doing all three at the same time would be small enough to be put into a single PR, but separate is definitely the "proper" solution :) |
JonLiu1993
added
info:reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
N/A. It updates
google-cloud-cppto the latest release (v1.28.0). One of the new things in this release is the-DGOOGLE_CLOUD_CPP_ENABLE_EXAMPLES=OFFoption, which eliminates the need fordisable-benchmarks.patch.Which triplets are supported/not supported? Have you updated the CI baseline?
No change.
Does your PR follow the maintainer guide?
Yes.
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes.